Old 09-24-2008, 12:37 AM   #1 (permalink)
Neat! I'm string! YAAAY!
 
Drahken's Avatar
 
Join Date: Nov 2007
Posts: 1,500
Default [FIXED][bug-solution] Star ratings on the next line on anime pages

This css related bug has been mentioned a few times in various threads, but has always gotten lost. I have found the problem, and it's a simple fix;
The problem lies in the use of the float property. Floated divs have to come BEFORE the content they are to be next to in the HTML. Putting a floated item after something else in the html will push it onto the next line. The solution comes in 3 parts:
1) Move the whole ratings div for the main anime (not the recs) from it's current location just before the </form> tag to just before the opening <form> tag.
2) Give the ratings div for the main anime on the page a different class from the ones for the recs on the page. Something like .starRatingMain perhaps.
3) Set this new class to float:right instead of float:left. (The recs on the page need the float:left setting to work properly, but the main rating needs float:right.)

Here's a shot of the bug: http://allspark.net/cypherswipe/rating-bug-before.png
Here's a shot of the fix (with the float property set to "right" for all the ratings on the page, you can see how that messes up the ones in the recs): http://allspark.net/cypherswipe/rating-bug-after.png
(Ignore other errors in the second screenshot, such as the missing images behind the screenshots.)
__________________
*Warning: The above post may be highly opinionated, read it at your own risk.

A little search goes a long way. . . . . . . . . . . . . . . . . . Help add anime
Drahken is offline   Reply With Quote
Old 09-24-2008, 01:49 AM   #2 (permalink)
Overlord
 
sothis's Avatar
 
Join Date: May 2002
Location: Seattle, Washington
Age: 27
Posts: 6,432
Default Re: [bug-solution] Star ratings on the next line on anime pages

i didnt read this, but we ended up fixing it in the last iteration of the codebase
sothis is offline   Reply With Quote
Reply

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off
Trackbacks are Off
Pingbacks are Off
Refbacks are On


All times are GMT -7. The time now is 06:14 AM.


Powered by vBulletin® Version 3.7.3
Copyright ©2000 - 2009, Jelsoft Enterprises Ltd.
Search Engine Friendly URLs by vBSEO 3.2.0